Add explicit flag to remove files not listed in navigation file #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flynneva
commented
Mar 23, 2023
| if not result: | ||
| result = nav_parser.resolve_yaml_nav(nav_data) | ||
| return result or [] | ||
| def _resolve_directories_in_nav( |
There was a problem hiding this comment.
@oprypin these changes were just to expose the nav_parser to the plugin by making this a method of the plugin.
flynneva
force-pushed
the
20-remove-files-if-excluded
branch
2 times, most recently
from
2f8112c to
6fa9577
Compare
Signed-off-by: Evan Flynn <evan.flynn@apex.ai>
flynneva
force-pushed
the
20-remove-files-if-excluded
branch
from
6fa9577 to
d2bafac
Compare
Signed-off-by: Evan Flynn <evan.flynn@apex.ai>
flynneva
force-pushed
the
20-remove-files-if-excluded
branch
from
98789fd to
46a948a
Compare
Rizalsabuga
approved these changes
May 30, 2023
|
@oprypin any way to move this forward? |
|
I would be happy to re-implement this PR too! |
reteps
reviewed
Mar 14, 2025
| or f not in files.documentation_pages() | ||
| ): | ||
| return True | ||
| log.warning(f"File excluded from navigation file: {f.src_uri}") |
There was a problem hiding this comment.
@flynneva Can you have this not emit a warning? This would fail strict doc builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20