Skip to content

Conversation

@mayoor
Copy link
Member

@mayoor mayoor commented Oct 30, 2024

Description

Adding support to input dsn in ADW secret to allow for TLS connections

Test Results

Save Creds

Screenshot 2024-10-30 at 9 21 15 AM

Fetch Creds

Screenshot 2024-10-30 at 9 24 16 AM

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 30, 2024
Add dsn attribute to ADWSecretKeeper
@mayoor mayoor force-pushed the secret_support_tls branch from 6f48b3c to 0164d10 Compare October 30, 2024 00:31
@github-actions
Copy link

📌 Cov diff with main:

Coverage-100%

📌 Overall coverage:

Coverage-58.62%

@mayoor mayoor marked this pull request as ready for review October 30, 2024 16:26
@github-actions
Copy link

github-actions bot commented Nov 1, 2024

📌 Cov diff with main:

Coverage-100%

📌 Overall coverage:

Coverage-58.61%

@mayoor mayoor merged commit 5ff0d48 into main Nov 1, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants