[GR-71654] [GR-72101] [GR-72102] Remove the Java heap allocation in AbstractCollectionPolicy.updateSizeParameters() + fixes and optimizations. #12752
+840
−333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR can be reviewed commit-by-commit.
AbstractCollectionPolicy.updateSizeParameters(). This makes it possible to callSystem.gc()from code that must be allocation free (was previously only possible for certain GC policies).RawSizeParameters).@Uninterruptiblecode (seeSizeParameters)AbstractCollectionPolicytoSizeParametersto ensure that they are updated atomically as well. Methods likeAbstractCollectionPolicy.getMaximumEdenSize()noew return consistent values, even if the heap size changes concurrently.AbstractCollectionPolicyso that it uses theIsolateArgumentParservalues. This fixes issues where wrong heap size values were used before the first garbage collection.onValueUpdate()methods to ensure that theIsolateArgumentParsersees the latest option values as well.OptionKey.afterValueUpdate()wasn't called correctly).