Mobile view and wording #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangecoding
requested changes
Jul 26, 2025
| @@ -38,7 +38,7 @@ export default function JobMutator() { | |||
| const dispatch = useDispatch(); | |||
|
|
|||
| const isSavingEnabled = () => { | |||
| return notificationAdapterData.length > 0 && providerData.length > 0 && name != null && name.length > 0; | |||
| return notificationAdapterData.length && providerData.length && name; | |||
There was a problem hiding this comment.
this is not exactly the same check than I had. in your case, setting name to ' ' would resolve truthy...
There was a problem hiding this comment.
You're right, it leads to a different result. I didn't notice that, it should be wrapped in a Boolean constructor.
The thing is,
console.log(Boolean('')) // falseAssuming notificationAdapter.length=1 and providerData.length=1 and name='':
console.log(1 && 1 && ''); // ''It works when wrapped though:
console.log(Boolean(1 && 1 && '')); // false
console.log(Boolean(1 && 1 && 'a')); // true
console.log(Boolean(1 && 1 && 'anythingelse')); // true| @@ -27,20 +27,24 @@ export default function Login() { | |||
| }, []); | |||
|
|
|||
| const tryLogin = async () => { | |||
| if (username.length === 0 || password.length === 0) { | |||
| setError('Username and password are mandatory.'); | |||
| if (!username?.trim() || !password) { | |||
There was a problem hiding this comment.
Tbh, I thought about using a toast here as well, but found that showing the in the login form directly looks nicer, therefor I think using a toast here is not ideal
There was a problem hiding this comment.
You meant just here, right? I changed it back, let me know if that's better :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR aims to:
Style changes preview:
As an example an iPhone 12 was used as mobile.