Skip to content

Conversation

@gaultier
Copy link

@gaultier gaultier commented May 8, 2025

Simply doing go install . will build from source (good) and then install the built executable in the GOPATH (still good) but under the very generic name cli (taken from the package name). We want to install it under the name ory (like in all the docs and the CLI help message).

Due to the current go install limitations we have to do go build -o ory . and then copy the executable.

PS: Also updated go.mod to fix critical vulnerabilities warnings.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added the necessary documentation within the code base (if
    appropriate).

Further comments

@gaultier gaultier force-pushed the pgaultier-build-install-from-source branch 4 times, most recently from a72762e to d672997 Compare May 8, 2025 08:49
@gaultier gaultier force-pushed the pgaultier-build-install-from-source branch from d672997 to 7ca3add Compare May 8, 2025 09:16
@gaultier gaultier changed the title feat(make): build the ory CLI from source and install it under the right name feat(make): build the ory cli from source and install it under the right name May 8, 2025
@gaultier gaultier changed the title feat(make): build the ory cli from source and install it under the right name docs: build the ory cli from source and install it under the right name May 8, 2025
@gaultier gaultier closed this Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants