Skip to content

Conversation

@jonas-jonas
Copy link
Member

Fixes a bug, where the project's CORS configuration was lost if either of the oauth2-config, identity-config or permissions-config was updated individually.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added the necessary documentation within the code base (if
    appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Aug 5, 2025
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe use the patch API instead and handle this server-side?

@jonas-jonas
Copy link
Member Author

Yea, but that endpoint works differently, and I really don't want to find out what bugs that would uncover... Let's just merge this, and keep an item in the backlog to refactor this. WDYT?

@jonas-jonas jonas-jonas merged commit 2aab03e into master Sep 3, 2025
16 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/fixOauth2UpdateCors branch September 3, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants