Skip to content

Conversation

@donporter
Copy link
Member

@donporter donporter commented Aug 24, 2020

Local mirror of SGX driver, tracking PR to fix build on 5.8 kernel and newer.

intel#120


This change is Reviewable

donporter added 2 commits July 6, 2020 11:38
Signed-off-by: Don Porter <porter@cs.unc.edu>
Copy link

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @donporter)

a discussion (no related file):
Could you link intel#120 in the PR description? (for bookkeeping)



sgx_encl.c, line 335 at r1 (raw file):

		mmap_read_unlock(encl->mm);
#else
 		up_read(&encl->mm->mmap_sem);

please drop this accidental space


sgx_page_cache.c, line 1 at r1 (raw file):

 /*

looks like accidental change?

Copy link
Member Author

@donporter donporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @mkow)

a discussion (no related file):

Previously, mkow (Michał Kowalczyk) wrote…

Could you link intel#120 in the PR description? (for bookkeeping)

Done.



sgx_encl.c, line 335 at r1 (raw file):

Previously, mkow (Michał Kowalczyk) wrote…

please drop this accidental space

Done.


sgx_page_cache.c, line 1 at r1 (raw file):

Previously, mkow (Michał Kowalczyk) wrote…

looks like accidental change?

Done.

Copy link

@mkow mkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @donporter)

a discussion (no related file):
Seems intel#120 was just merged, so we don't need this subrepo, at least for now :)



sgx_encl.c, line 335 at r1 (raw file):

Previously, donporter (Don Porter) wrote…

Done.

Not done?


sgx_page_cache.c, line 1 at r1 (raw file):

Previously, donporter (Don Porter) wrote…

Done.

Not done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants