Skip to content

Conversation

@Kiyazz
Copy link
Contributor

@Kiyazz Kiyazz commented Dec 1, 2025

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7188

Purpose

This PR will make it possible for collections to be sorted on their stats, specifically number of works and bookmarks. It will respect counts of works/bookmarks for private works when logged out

References

AO3-7143 should also be able to recieve these changes if done first
EDIT: Since AO3-7143 is in review as well, there will be merge conflicts with it. Advice on how to resolve would be good

Credit

kiyazz (he/him)

@Kiyazz
Copy link
Contributor Author

Kiyazz commented Dec 1, 2025

I know there are some rspec test cases failing right now. I'm not sure if this functionality is even possible to test with rspec since it's reliant on a column that only exists in elasticsearch and not in the database proper

@Kiyazz
Copy link
Contributor Author

Kiyazz commented Dec 2, 2025

Rspec is figured out, I'm still unsure about the one rubocop error I had to comment out. Any fix for that would cause test failures everywhere else and take tons of refactoring to solve so I thought it best to ignore that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants