Skip to content

Conversation

@ej-sanmartin
Copy link
Contributor

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7196

Purpose

What does this PR do?

Add suspended/banned status upon login.

Testing Instructions

Went through test instruction through Jira, added .feature tests

Credit

Edgar San Martin, Jr. (Jira issue already claimed by myself).

@ej-sanmartin
Copy link
Contributor Author

rubocop was also throwing multiple errors due in sessions_controller.rb and application_controller.rb so cleaned those up, as well.

@Bilka2
Copy link
Contributor

Bilka2 commented Dec 16, 2025

rubocop was also throwing multiple errors due in sessions_controller.rb and application_controller.rb so cleaned those up, as well.

If you touch a lot of unrelated parts of the files like you did here it makes reviewing a lot harder and merge conflicts much more likely. As is, a lot of the fixes also aren't desired code style, e.g. we'd want to use redirecting to root_path over /, i18n the errors and more. Fixing all that would add a lot of extra back and forth to what could be a more simple change here. So please revert the extra corrections and focus them only on the lines you added/changed, thank you!

@Bilka2 Bilka2 changed the title AO3-7196 Show supended/banned status upon login. AO3-7196 Show supended/banned status upon login Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants