Skip to content

AO3-7184 When visiting a nonexistent user's related works, give 404 instead of an error and a redirect #5522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bilka2 merged 1 commit into from
Dec 28, 2025
Merged

AO3-7184 When visiting a nonexistent user's related works, give 404 instead of an error and a redirect #5522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions app/controllers/related_works_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,7 @@ def destroy
private

def load_user
if params[:user_id].blank?
flash[:error] = ts("Whose related works were you looking for?")
redirect_to search_people_path
else
@user = User.find_by(login: params[:user_id])
if @user.blank?
flash[:error] = ts("Sorry, we couldn't find that user")
redirect_to search_people_path
end
end
@user = User.find_by!(login: params[:user_id])
end

def get_instance_variables
Expand Down
18 changes: 6 additions & 12 deletions spec/controllers/related_works_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,16 @@

describe "GET #index" do
context "for a blank user" do
before(:each) do
get :index, params: { user_id: "" }
end

it "sets a flash message and redirects the requester" do
it_redirects_to_with_error(search_people_path, "Whose related works were you looking for?")
it "raises a RecordNotFound error" do
expect { get :index, params: { user_id: "" } }
.to raise_error(ActiveRecord::RecordNotFound)
end
end

context "for a nonexistent user" do
before(:each) do
get :index, params: { user_id: "user" }
end

it "sets a flash message and redirects the requester" do
it_redirects_to_with_error(search_people_path, "Sorry, we couldn't find that user")
it "raises a RecordNotFound error" do
expect { get :index, params: { user_id: "user" } }
.to raise_error(ActiveRecord::RecordNotFound)
end
end

Expand Down
Loading