Skip to content

Conversation

@Hephaest
Copy link
Contributor

@Hephaest Hephaest commented Aug 4, 2025

Hi Team,

I'm working on your API recently and found this annoying TS error:
image

I believed this was made by mistake so I fixed it by myself and done the self-testing:
image

Please help merge this PR so it can help save more developers' time. In the worst case, it can block the project deployment if there's a TS lint check in CI:
image

@Hephaest
Copy link
Contributor Author

Hephaest commented Aug 4, 2025

Hi @kseniia-maiesh Could you help review this PR?

@kseniia-maiesh kseniia-maiesh self-requested a review August 12, 2025 21:00
@kseniia-maiesh
Copy link
Contributor

Hi @kseniia-maiesh Could you help review this PR?

Hi. Sure!

@Hephaest
Copy link
Contributor Author

Hephaest commented Aug 13, 2025

Hi @kseniia-maiesh Could you help review this PR?

Hi. Sure!

Great! Thanks! @kseniia-maiesh

I will create another PR this week to address a bug that relies on this code change. Could you help merge this PR so we can avoid any code conflicts? Thank you!

@vlad-stack vlad-stack merged commit 946dd4c into outscraper:main Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants