Skip to content

Conversation

@dschmidt
Copy link
Member

@dschmidt dschmidt commented Nov 11, 2025

Description

Fixes the type of the WEB_OPTION_EMBED_ENABLED option.

Related Issue

Motivation and Context

When I set this via the env var, this lead to an error in the web ui.

ZodError: [
  {
    "code": "invalid_type",
    "expected": "boolean",
    "received": "string",
    "path": [
      "options",
      "embed",
      "enabled"
    ],
    "message": "Expected boolean, received string"
  }
]
    at get error (PortalTarget.vue_vue_type_script_lang-bXzn9CRK.mjs:22:365359)
    at zt.parse (PortalTarget.vue_vue_type_script_lang-bXzn9CRK.mjs:22:367618)
    at d$ (index.html-BwE7xvlA.mjs:6:311919)
    at async Object.F$ [as bootstrapApp] (index.html-BwE7xvlA.mjs:6:322800)
U$ @ index.html-BwE7xvlA.mjs:6

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@dschmidt dschmidt requested a review from LukasHirt as a code owner November 11, 2025 18:20
@update-docs
Copy link

update-docs bot commented Nov 11, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

@mmattel
Copy link
Contributor

mmattel commented Nov 12, 2025

@dschmidt 👋 mind to add a changelog?

@mklos-kw mklos-kw force-pushed the fix/embed-enabled-bool branch from 7cfc45b to daeebfb Compare January 5, 2026 14:57
fix: implement *bool config type, so Embed.Enabled can still be explicitly disabled

feat: added changelog

fix: sanitize config
@mklos-kw mklos-kw force-pushed the fix/embed-enabled-bool branch from daeebfb to 51b2f97 Compare January 5, 2026 16:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WEB_OPTION_EMBED_ENABLED cannot be used because it's a string type

4 participants