Skip to content

fix(linter): postmessage is not called on window (#12026) #14192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(linter): postmessage is not called on window (#12026) #14192

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb72047
fix(linter/plugins): postmessage is not called on window (#12026)
Kenzo-Wada Sep 27, 2025
e7c2611
Update crates/oxc_linter/src/rules/unicorn/require_post_message_targe…
Kenzo-Wada Sep 27, 2025
f4980a7
Merge branch 'main' into fix/unicorn-linter-postmessage
Kenzo-Wada Sep 28, 2025
ba8577a
Merge branch 'main' into fix/unicorn-linter-postmessage
Kenzo-Wada Sep 29, 2025
e6acf5a
Merge branch 'main' into fix/unicorn-linter-postmessage
Kenzo-Wada Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions crates/oxc_linter/src/rules/unicorn/require_post_message_target_origin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ impl Rule for RequirePostMessageTargetOrigin {
_ => return,
};
if matches!(member_expr.static_property_name(), Some(name) if name == "postMessage") {
if is_message_port_expression(member_expr.object()) {
return;
}
let span = call_expr.arguments[0].span();
ctx.diagnostic_with_suggestion(
require_post_message_target_origin_diagnostic(Span::new(span.end, span.end)),
Expand All @@ -79,6 +82,36 @@ impl Rule for RequirePostMessageTargetOrigin {
}
}

fn is_message_port_expression(expr: &Expression<'_>) -> bool {
let expr = expr.without_parentheses();

if let Expression::Identifier(ident) = expr
&& matches!(ident.name.as_str(), "port" | "port1" | "port2" | "messagePort")
Copy link

Copilot AI Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The hardcoded identifier names 'port', 'port1', 'port2', 'messagePort' are magic strings that could be extracted to constants for better maintainability and reusability.

Copilot uses AI. Check for mistakes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there was a place where it was hardcoded like Some(name) if name == "postMessage", I've left it as is for now.

{
return true;
}

let Some(member_expr) = expr.get_member_expr() else {
return false;
};

if member_expr.static_property_name().is_some_and(|name| matches!(name, "port1" | "port2")) {
return true;
}

if member_expr.is_computed()
&& member_expr.object().without_parentheses().get_member_expr().is_some_and(
|object_member| {
object_member.static_property_name().is_some_and(|name| name == "ports")
},
)
{
return true;
}

is_message_port_expression(member_expr.object())
}

#[test]
fn test() {
use crate::tester::Tester;
Expand All @@ -101,6 +134,10 @@ fn test() {
"window.c.postMessage?.(message)",
"window.a.b?.postMessage(message)",
"window?.a?.b?.postMessage(message)",
"event.ports[0].postMessage(message)",
"channel.port1.postMessage(message)",
"channel['port2'].postMessage(message)",
"event?.ports[0].postMessage(message)",
];

let fail = vec![
Expand Down