Skip to content

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 3, 2025

Added a way to add custom compat data that doesn't exist in compat table. Also added the data for "export namespace from".

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Oct 3, 2025
Copy link
Member Author

sapphi-red commented Oct 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Oct 3, 2025

CodSpeed Instrumentation Performance Report

Merging #14317 will not alter performance

Comparing 10-03-feat-compat-add-custom-compat-data-for-export-namespace-from (be53dad) with main (34e1c0b)

Summary

✅ 33 untouched
⏩ 4 skipped1

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sapphi-red sapphi-red marked this pull request as ready for review October 3, 2025 14:08
@Copilot Copilot AI review requested due to automatic review settings October 3, 2025 14:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for custom compatibility data that doesn't exist in the compat-table by creating a new infrastructure for manually maintained browser support information. The key change is the addition of compatibility data for the "export namespace from" ES2020 feature.

  • Creates a custom compatibility data system for features not in compat-table
  • Adds specific browser version support data for "export namespace from" syntax
  • Integrates custom data into the build process alongside existing compat-table data

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tasks/compat_data/custom-compat-data.js New file defining custom compatibility data structure and ES2020 export namespace from support
tasks/compat_data/build.js Integrates custom compatibility data into the build process
tasks/compat_data/data.json Generated output containing the new ExportNamespaceFrom compatibility data
crates/oxc_compat/src/es_features.rs Adds ES2020ExportNamespaceFrom enum variant and corresponding engine targets

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sapphi-red sapphi-red requested a review from Dunqing October 3, 2025 14:58
@sapphi-red sapphi-red force-pushed the 10-03-feat-compat-add-custom-compat-data-for-export-namespace-from branch from 7261530 to 13f3e7b Compare October 3, 2025 15:59
@sapphi-red sapphi-red force-pushed the 10-03-feat-compat-add-custom-compat-data-for-export-namespace-from branch from 13f3e7b to be53dad Compare October 4, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants