fix(linter): fix flaky import/no_cycle test

[Boshen]

Summary

Fixes the flaky import/no_cycle test that was failing 2/10 times on Linux CI.

Root Cause

The module graph is populated via parallel insertion (par_drain in runtime.rs), which causes non-deterministic insertion order into FxHashMap. Since hashmap iteration order depends on insertion order, this leads to:

1. Different iteration orders across test runs
2. Different graph traversal paths in the cycle detector
3. The traversed set preventing revisiting nodes means cycles can be found or missed depending on which path is explored first

Solution

Sort the hashmap entries by key before iterating in module_graph_visitor.rs to ensure deterministic traversal order regardless of parallel insertion timing.

Test Plan

• cargo test -p oxc_linter no_cycle passes
• Code formatted with just fmt

🤖 Generated with Claude Code

[graphite-app]

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[Copilot]

Pull Request Overview

This PR fixes a flaky test in the import/no_cycle linter rule by addressing non-deterministic module graph traversal order. The test was failing intermittently (2/10 times) on Linux CI due to race conditions in parallel module loading.

• Identifies root cause as non-deterministic FxHashMap insertion order from parallel operations
• Implements deterministic sorting of module graph entries before iteration
• Ensures consistent cycle detection behavior across test runs

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #14328 will not alter performance

_{Comparing fix-no-cycle-flaky (f1bc608) with main (588acd5)¹}

Summary

✅ 4 untouched
⏩ 33 skipped²

Footnotes

1. No successful run was found on main (f1bc608) during the generation of this report, so 588acd5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Boshen]

Merge activity

• Oct 5, 3:27 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 5, 3:27 PM UTC: Boshen added this pull request to the Graphite merge queue.
• Oct 5, 3:31 PM UTC: Merged by the Graphite merge queue.