Skip to content

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Oct 4, 2025

Summary

fixes #12796

  • Added target ES2026
  • Moves the explicit resource management feature from proposals to ES2026, as it is now a finalized ECMAScript 2026 feature.

🤖 Generated with Claude Code

@Boshen Boshen requested a review from overlookmotel as a code owner October 4, 2025 09:56
@Copilot Copilot AI review requested due to automatic review settings October 4, 2025 09:56
@Boshen Boshen requested a review from Dunqing as a code owner October 4, 2025 09:56
Copy link
Contributor

graphite-app bot commented Oct 4, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves the explicit resource management feature from the proposals module to ES2026, reflecting its finalization in the ECMAScript 2026 specification.

  • Creates a new ES2026 module structure with options and transformer implementation
  • Updates the transformer to use ES2026 instead of proposals for explicit resource management
  • Cleans up the proposals module by removing the explicit resource management code

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/oxc_transformer/src/proposals/options.rs Removes explicit_resource_management field and simplifies ProposalOptions
crates/oxc_transformer/src/proposals/mod.rs Removes explicit resource management module imports
crates/oxc_transformer/src/options/mod.rs Updates BabelOptions integration to use ES2026Options
crates/oxc_transformer/src/options/env.rs Adds ES2026Options to EnvOptions with explicit resource management support
crates/oxc_transformer/src/lib.rs Replaces proposals-based transform with ES2026 module integration
crates/oxc_transformer/src/es2026/options.rs Defines ES2026Options with explicit resource management field
crates/oxc_transformer/src/es2026/mod.rs Implements ES2026 transformer with explicit resource management support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Oct 4, 2025
@Boshen Boshen self-assigned this Oct 4, 2025
@Boshen Boshen marked this pull request as draft October 4, 2025 09:58
Copy link

codspeed-hq bot commented Oct 4, 2025

CodSpeed Instrumentation Performance Report

Merging #14330 will not alter performance

Comparing feat/move-explicit-resource-management-to-es2026 (588acd5) with main (81a28d4)

Summary

✅ 37 untouched

@Boshen Boshen force-pushed the feat/move-explicit-resource-management-to-es2026 branch 2 times, most recently from 2801e38 to 7df26e2 Compare October 5, 2025 03:30
@Boshen Boshen changed the title feat(transformer): move explicit resource management to ES2026 feat(transformer): add ES2026 target for explicit resource management Oct 5, 2025
@Boshen Boshen marked this pull request as ready for review October 5, 2025 03:31
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 5, 2025
Copy link
Member Author

Boshen commented Oct 5, 2025

Merge activity

@Boshen Boshen force-pushed the feat/move-explicit-resource-management-to-es2026 branch from 18d64c1 to ed68072 Compare October 5, 2025 07:07
…#14330)

## Summary

fixes #12796

* Added target `ES2026`
* Moves the explicit resource management feature from proposals to ES2026, as it is now a finalized ECMAScript 2026 feature.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@graphite-app graphite-app bot force-pushed the feat/move-explicit-resource-management-to-es2026 branch from ed68072 to 588acd5 Compare October 5, 2025 07:12
@graphite-app graphite-app bot merged commit 588acd5 into main Oct 5, 2025
27 checks passed
@graphite-app graphite-app bot deleted the feat/move-explicit-resource-management-to-es2026 branch October 5, 2025 07:18
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 5, 2025
@Boshen Boshen mentioned this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using syntax is transformed even if target: 'esnext' is set
1 participant