fix(pubsub): ensure immediate message retry when noAck=true and processing fails #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that with noAck enabled ack message when handling message successfully, and nack it when handling it fails
Added tests to verify message acknowledgment behavior based on the noAck configuration. This includes scenarios for successful and failed message handling, ensuring proper acknowledgment and negative acknowledgment as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Google Pub/Sub message retry behavior when noAck=true
Problem:
• When
noAck=truewas set, failed messages weren't retried immediately• Messages only retried after the acknowledgment timeout, not according to retry policy
• This caused unexpected delays in message processing
Solution:
• Library now explicitly sends
nackwhen message processing fails• Failed messages retry immediately based on configured retry policy
• Removes silent delays in message reprocessing
Impact:
• More predictable error handling behavior
• Retry policies now work as expected
• Library handles both
ackandnackautomatically whennoAck=true@p-fedyukovich