GH1317 Set defaults #1491
Merged
GH1317 Set defaults #1491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmp0xff
requested changes
Nov 16, 2025
Contributor
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
Just managed to review pandas-stubs/core/indexes/interval.pyi. Will check the other two files later.
cmp0xff
requested changes
Nov 17, 2025
Contributor
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
Please double check readers.pyi. I do not necessarily make the same suggestion in all overloads.
cmp0xff
requested changes
Nov 18, 2025
Contributor
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
I have reviewed all changes.
Member
Author
|
@cmp0xff I should have tackled all the feedback, thanks for that! |
cmp0xff
requested changes
Nov 18, 2025
Contributor
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
I think that's all comments from my side. Let's wait for https://github.com/pandas-dev/pandas-stubs/pull/1491/files#r2537067277.
Co-authored-by: Yi-Fan Wang <cmp0xff@users.noreply.github.com>
Co-authored-by: Yi-Fan Wang <cmp0xff@users.noreply.github.com>
cmp0xff
approved these changes
Nov 25, 2025
Contributor
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
Thank you @loicdiridollou !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value