MAINT: #1514 🌃 fix nightly

[cmp0xff]

• Closes Broken nightly #1514

[Dr-Irv]

I'd like to do a release soon, so maybe when this one is complete, I could do a release? Or wait for something else? Thoughts @cmp0xff ?

[cmp0xff]

I'd like to do a release soon, so maybe when this one is complete, I could do a release? Or wait for something else? Thoughts @cmp0xff ?

This one does not affect the typing for Pandas 2.3.x. I think we can do the release sooner or now.

[cmp0xff]

/pandas_nightly

[cmp0xff]

The remaining errors in nightly are

FAILED tests/indexes/arithmetic/bool/test_truediv.py::test_truediv_py_sequence - NotImplementedError: operator 'truediv' not implemented for bool dtypes
FAILED tests/indexes/arithmetic/timedeltaindex/test_floordiv.py::test_floordiv_py_sequence - RuntimeError: Expected type '<class 'int'>' but got '<class 'numpy.longlong'>'
FAILED tests/series/arithmetic/bool/test_truediv.py::test_truediv_py_sequence - NotImplementedError: operator 'truediv' not implemented for bool dtypes
FAILED tests/series/arithmetic/timedelta/test_floordiv.py::test_floordiv_py_sequence - RuntimeError: Expected type '<class 'int'>' but got '<class 'numpy.longlong'>'

These are independent of pandas-dev/pandas#63195.

[Dr-Irv]

I'd like to do a release soon, so maybe when this one is complete, I could do a release? Or wait for something else? Thoughts @cmp0xff ?

This one does not affect the typing for Pandas 2.3.x. I think we can do the release sooner or now.

OK - I've done the release of 2.3.3.251201

[Dr-Irv]

The remaining errors in nightly are

FAILED tests/indexes/arithmetic/bool/test_truediv.py::test_truediv_py_sequence - NotImplementedError: operator 'truediv' not implemented for bool dtypes
FAILED tests/indexes/arithmetic/timedeltaindex/test_floordiv.py::test_floordiv_py_sequence - RuntimeError: Expected type '<class 'int'>' but got '<class 'numpy.longlong'>'
FAILED tests/series/arithmetic/bool/test_truediv.py::test_truediv_py_sequence - NotImplementedError: operator 'truediv' not implemented for bool dtypes
FAILED tests/series/arithmetic/timedelta/test_floordiv.py::test_floordiv_py_sequence - RuntimeError: Expected type '<class 'int'>' but got '<class 'numpy.longlong'>'

These are independent of pandas-dev/pandas#63195.

For the 2 test_truediv_py errors, those are really bugs in 2.3 and 3.0 behavior is correct, so let's change the test to place if PD_LTE_23 around the ones that fail when dividing by a boolean sequence or vice versa.

For the 2 ones involving Timedelta, can we dynamically type the check based on PD_LTE_23 ?

[cmp0xff]

/pandas_nightly

[cmp0xff]

For the 2 test_truediv_py errors, those are really bugs in 2.3 and 3.0 behavior is correct, so let's change the test to place if PD_LTE_23 around the ones that fail when dividing by a boolean sequence or vice versa.

Not too sure, I've raised pandas-dev/pandas#63250. Also the changes are affected by python/mypy#20061.

For the 2 ones involving Timedelta, can we dynamically type the check based on PD_LTE_23 ?

I did it.

[Dr-Irv]

thanks @cmp0xff