-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
BUG: fix to_json() with JSON Table Schema work correctly with string dtype #61900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! (just added a brief whatsnew note)
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Thanks @khemkaran10! |
…dtype (pandas-dev#61900) Co-authored-by: Khemkaran <sunny@Khemkaran-MacBook-Pro.local> Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Manual backport -> #61965 |
Fixes: #61889
To ensure consistent behavior for to_json(), when dtype="str" is used, it will now output "type": "string" instead of "type": "any".
Before Fix:
After Fix:
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.