-
-
Notifications
You must be signed in to change notification settings - Fork 18.9k
BUG: DataFrame.rank does not return EA types when original type was an EADtype #62189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
BUG: DataFrame.rank does not return EA types when original type was an EADtype #62189
Conversation
doc/source/whatsnew/v3.0.0.rst
Outdated
@@ -204,6 +204,7 @@ Other enhancements | |||
- :meth:`.DataFrameGroupBy.transform`, :meth:`.SeriesGroupBy.transform`, :meth:`.DataFrameGroupBy.agg`, :meth:`.SeriesGroupBy.agg`, :meth:`.SeriesGroupBy.apply`, :meth:`.DataFrameGroupBy.apply` now support ``kurt`` (:issue:`40139`) | |||
- :meth:`DataFrame.apply` supports using third-party execution engines like the Bodo.ai JIT compiler (:issue:`60668`) | |||
- :meth:`DataFrame.iloc` and :meth:`Series.iloc` now support boolean masks in ``__getitem__`` for more consistent indexing behavior (:issue:`60994`) | |||
- :meth:`DataFrame.rank` now uses internal ``_mgr.apply`` and preserves the dtype for extension arrays (:issue:`52829`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don’t need to mention mgr, just the user-facing bit
In the axis=1 case you need to transpose the whole dataframe, not block-by-block |
doc/source/whatsnew/v3.0.0.rst
Outdated
@@ -204,6 +204,7 @@ Other enhancements | |||
- :meth:`.DataFrameGroupBy.transform`, :meth:`.SeriesGroupBy.transform`, :meth:`.DataFrameGroupBy.agg`, :meth:`.SeriesGroupBy.agg`, :meth:`.SeriesGroupBy.apply`, :meth:`.DataFrameGroupBy.apply` now support ``kurt`` (:issue:`40139`) | |||
- :meth:`DataFrame.apply` supports using third-party execution engines like the Bodo.ai JIT compiler (:issue:`60668`) | |||
- :meth:`DataFrame.iloc` and :meth:`Series.iloc` now support boolean masks in ``__getitem__`` for more consistent indexing behavior (:issue:`60994`) | |||
- :meth:`DataFrame.rank` now preserves the dtype for extension arrays (:issue:`52829`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be dtype_backend, not dtype?
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.I rewrote the method using
_mgr.apply
but still struggling to figure out why 2 oftest_rank.py
test cases are failing. Any help or tips are appreciated! They are as follows: