Skip to content

Conversation

@wisznie
Copy link

@wisznie wisznie commented Nov 4, 2025

Continuing on the work done in #61659

@wisznie wisznie changed the title Bugfix to numeric when pyarrow with na continuation BUG: to_numeric fails to convert a Pyarrow Decimal series containing NA values Nov 4, 2025
@wisznie
Copy link
Author

wisznie commented Nov 12, 2025

I see test breakage because I didn't correctly skip pyarrow tests in my parameterization. I'll fix that today.

"pyarrow_dtype",
[
pytest.param(
pa.int8(), marks=pytest.mark.skipif(not pa, reason="pyarrow required")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the current approach doesn't work, I think it's fine to parametrize the attribute and arguments, and use pytest.importorskip with getattr to construct the type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: to_numeric fails to convert a Pyarrow Decimal series containing NA values.

3 participants