Skip to content

Conversation

@AnonToky
Copy link
Contributor

@AnonToky AnonToky commented Nov 19, 2025

@AnonToky AnonToky changed the title replace @doc @appender with inline docstringsin pandas/core/indexes/datetimelike.py DOC: replace @doc @appender with inline docstringsin pandas/core/indexes/datetimelike.py Nov 19, 2025
@AnonToky
Copy link
Contributor Author

pre-commit.ci autofix

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many of the docstrings here are changing. I think we want the contents to remain the same.

@AnonToky AnonToky requested a review from rhshadrach November 25, 2025 10:50
Added doc decorators to methods for better documentation integration.
@AnonToky
Copy link
Contributor Author

AnonToky commented Nov 25, 2025

Many of the docstrings here are changing. I think we want the contents to remain the same.

hi I just revoke my previous changes in @doc, reamin the changes in @appender, will this be ok? I'm new in contributing to this issue and hope to get your guidance, thx

@AnonToky
Copy link
Contributor Author

pre-commit.ci autofix

@rhshadrach
Copy link
Member

rhshadrach commented Nov 25, 2025

The docstring is still changing from what is there currently, it should match this:

_index_shared_docs["take"] = """

@AnonToky
Copy link
Contributor Author

pre-commit.ci autofix

@AnonToky
Copy link
Contributor Author

The docstring is still changing from what is there currently, it should match this:

_index_shared_docs["take"] = """

I have changed the docstring accroding to it

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

**kwargs,
) -> Self:
"""
Return a new %(klass)s of the values selected by the indices.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%(klass)s ends up as just Index in the docs for e.g. DatetimeIndex.take. Can you replace here.

@rhshadrach rhshadrach added Docs Index Related to the Index class or subclasses labels Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs Index Related to the Index class or subclasses

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants