Skip to content

Conversation

keldonin
Copy link
Collaborator

@keldonin keldonin commented Aug 28, 2024

This PR implements C_CopyObject(). It takes a template as an optional argument (i.e. Option<&[Attribute]>).

The PR comes along with rustdoc and dedicated test case.

Signed-off-by: Eric Devolder <eric.devolder@gmail.com>
Signed-off-by: Eric Devolder <eric.devolder@gmail.com>
hug-dev
hug-dev previously approved these changes Aug 28, 2024
Copy link
Member

@hug-dev hug-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Signed-off-by: Eric Devolder <eric.devolder@gmail.com>
@keldonin
Copy link
Collaborator Author

The CI script fails for the reason described in #216, can this be looked at? I guess it will block all PRs going forward.

Thank you!

hug-dev
hug-dev previously approved these changes Aug 30, 2024
Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite good 👍 . A couple of nitpicks :)

Signed-off-by: Eric Devolder <eric.devolder@gmail.com>
Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. LGTM 👍

I just noticed that the template info is explained in the second sentence of the function doc 🤦‍♂️

😅

Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@hug-dev hug-dev merged commit e0a9e17 into parallaxsecond:main Sep 2, 2024
@keldonin keldonin deleted the implement_session_copy_object branch September 2, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants