Remove skipping of kryoptic tests as they should work now #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakuje
force-pushed
the
kryoptic-fixed
branch
3 times, most recently
from
e6b7b19 to
e772f7e
Compare
They are fixed in 1.1.0 release Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
wiktor-k
approved these changes
Apr 18, 2025
hug-dev
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I introduced kryoptic tests, some of them were failing because of kryoptic bugs. These were fixed now and the skipping should not be needed anymore. I just updated the kryoptic package in Fedora, but it might take some time before it will land in mirrors so it might need some rerun later. I will keep an eye on that.
Contains also fix for the clippy as the #255 is not yet merged (this fix should have been a separate PR ...).