context: Avoid clippy errors #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sounds like something got updated somewhere and this started showing up |
wiktor-k
previously approved these changes
Jul 7, 2025
Yeah, the usual Rust update that introduces more lints. Thanks for catching this 👍 |
error: variables can be used directly in the `format!` string
--> cryptoki/src/context/general_purpose.rs:161:9
|
161 | write!(f, "Function::{:?}", self)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-D clippy::uninlined-format-args` implied by `-D clippy::all`
= help: to override `-D clippy::all` add `#[allow(clippy::uninlined_format_args)]`
Many similar also lived in tests
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
wiktor-k
approved these changes
Jul 7, 2025
|
And sounds like I missed the ones in tests. Fixed now also the ones in tests, please have another look. But they are really just mechanical changes |
wiktor-k
approved these changes
Jul 7, 2025
hug-dev
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error: variables can be used directly in the
format!string--> cryptoki/src/context/general_purpose.rs:161:9
|
161 | write!(f, "Function::{:?}", self)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note:
-D clippy::uninlined-format-argsimplied by-D clippy::all= help: to override
-D clippy::alladd#[allow(clippy::uninlined_format_args)]