klvparser: Add support for keys that are BER OIDs #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nexton-winjeel
force-pushed
the
misb0601-keys-are-ber-oids
branch
from
0a86a4e to
ff0b3aa
Compare
Collaborator
|
thanks @nexton-winjeel , Can we merge @paretech ? |
Owner
|
Hi @nexton-winjeel, thank you for your interest and contributions to this project! Would you be able to make additions to the test suite to cover these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MISB0601 and MISB0102 keys are encoded as BER OIDs (where keys greater than 127 are encoded in two or more bytes).
This PR updates
KLVParserto parse keys as BER OIDs when thekey_lengthis set toNone.