move plugins declaration below production #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version is working fine on CentOS, but on Windows10 I encountered this problem: the `webpack.DefinePlugin` replaces `__ENV__` before the `env = "prod";` is executed. Resulting in a production build, but the global var is still set to "dev".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running a production build on CentOS or Windows10 I encountered the following problem:
the
webpack.DefinePlugin()replaces__ENV__before theenv = "prod";is executed. Resulting in a production build, but the global variable is still set to "dev".I was pulling my hair out before and while encountering this
Can someone confirm this?