Fix typos in docstrings, error messages, and verbose output #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous step variable printed as a verbose output was the n-mpc step, which remained constant for n-mpc steps when n-mpc was greater than 1. Now, the step variable printed is the actual control step.
- Rename `y_r_param` to `y_s_param` in the docstring of the `set_input_output_setpoints` method, as it was a typo. - Remove leftover comment.
Replace `self.y_s.shape` with `self.y_r.shape` in the `ValueError` message of the `set_output_setpoint` method, as it was a typo.
|
All checks have passed, and the fixes look good. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes typos in controller docstrings and error messages. Additionally, it updates the verbose output in data-driven MPC closed-loop simulation functions to print the current time step.
Key changes:
set_input_output_setpointsmethod ofLTIDataDrivenMPCController.set_output_setpointmethod ofNonlinearDataDrivenMPCController.data_driven_mpc_sim.py) to reflect the actual control step instead of the n-mpc step.