-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: adds new experimental.localizeStatus option #13207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d589c0e
to
8a9caef
Compare
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a lot of manual testing, this looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found an issue after I approved this one.
When you have changes in one locale and then use the locale switcher, your content edits will be lost when you go back to the locale you were editing on. I tested in main to confirm that the current behavior allows editing in a locale and toggling back and forth without losing the edit.
See recording of the issue:
What?
Adds a new
experimental.localizeStatus
config option, set tofalse
by default. Whentrue
, the admin panel will display the document status based on the current locale instead of the latest overall status. Also updates the edit view to only show achanged
status whenautosave
is enabled.Why?
Showing the status for the current locale is more accurate and useful in multi-locale setups. This update will become default behavior, able to be opted in by setting
experimental.localizeStatus: true
in the Payload config. This option will become depreciated in V4.How?
When
localizeStatus
istrue
, we store the localized status in a newlocaleStatus
field group within version data. The admin panel then reads from this field to display the correct status for the current locale.