-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(plugin-multi-tenant): prefer assigned tenants for selector population #13213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
paulpopus
approved these changes
Jul 25, 2025
DanRibbens
pushed a commit
that referenced
this pull request
Aug 5, 2025
…present (#13365) Extension of #13213 This PR correctly filters tenants, users and documents based on the users assigned tenants if any are set. If a user is assigned tenants then list results should only show documents with those tenants (when selector is not set). Previously you could construct access results that allows them to see them, but in the confines of the admin panel they should not see them. If you wanted a user to be able to see a "public" tenant while inside the admin panel they either need to be added to the tenant or have no tenants at all. Note that this is for filtering only, access control still controls what documents a user has _access_ to a document. The filters are and always have been a way to filter out results in the list view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When populating the selector it should populate it with assigned tenants before fetching all tenants that a user has access to.
You may have "public" tenants and while a user may have access to the tenant, the selector should show the ones they are assigned to. Users with full access are the ones that should be able to see the public ones for editing.