fix(db-mongodb): disable join aggregations in DocumentDB compatibility mode #13270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorbg
changed the title
DanRibbens
previously approved these changes
Jul 25, 2025
auto-merge was automatically disabled
July 25, 2025 13:37
Head branch was pushed to by a user without write access
|
Thanks for the quick review @DanRibbens! Turns out, the CI found some more typos which I didn't fix. So I had to push another commit which automatically dismissed your review |
DanRibbens
approved these changes
Aug 20, 2025
|
🚀 This is included in version v3.53.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The PR #12763 added significant improvements for third-party databases that are compatible with the MongoDB API. While the original PR was focused on Firestore, other databases like DocumentDB also benefit from these compatibility features.
In particular, the aggregate JOIN strategy does not work on AWS DocumentDB and thus needs to be disabled. The current PR aims to provide this as a sensible default in the
compatibilityOptionsthat are provided by Payload out-of-the-box.As a bonus, it also fixes a small typo from
compat(a)bilitytocompat(i)bility.Why?
Because our Payload instance, which is backed by AWS DocumentDB, crashes upon trying to access any
joinfield.How?
By adding the existing
useJoinAggregationswith valuefalseto the compatiblity layer. Individual developers can still choose to override it in their own local config as needed.