Handling Table Names with / in Airtable API Requests
#66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vini-machado
changed the title
/ in Airtable API Requests
vini-machado
commented
Feb 10, 2025
| message=error_json.get('message', json.dumps(response.json()))) | ||
|
|
||
| error_json = response.json() | ||
| if isinstance(error_json, dict) and "error" in error_json: |
pcorpet
requested changes
Feb 12, 2025
| @@ -94,18 +95,29 @@ def __init__(self, base_id, api_key, dict_class=OrderedDict): | |||
| def __request(self, method, url, params=None, payload=None): | |||
| if method in ['POST', 'PUT', 'PATCH']: | |||
| self.headers.update({'Content-type': 'application/json'}) | |||
|
|
|||
| encoded_url = posixpath.join(self.base_url, urllib.parse.quote(url, safe="")) | |||
There was a problem hiding this comment.
Please don't quote the whole url once you're here. Instead quote the table_name in the other functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When making API requests to Airtable, table names that contain a
/(e.g., Subscriptions/Contracts) cause request failures because the / is interpreted as a path separator. The requests library does not automatically handle this, leading to an invalid URL.Expected Behavior
%2F, ensuring a valid API request./in the table name.