Fixes 2 sync and UI bugs in music-together plugin #4071
+66
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| import type { Permission, Profile, VideoData } from './types'; | ||
|
|
||
| export type ConnectionEventMap = { | ||
| CLEAR_QUEUE: {}; |
Contributor
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/no-empty-object-type> reported by reviewdog 🐶
The {} ("empty object") type allows any non-nullish value, including literals like 0 and "".
- If that's what you want, disable this lint rule with an inline comment or configure the 'allowObjectTypes' rule option.
- If you want a type meaning "any object", you probably want
objectinstead. - If you want a type meaning "any value", you probably want
unknowninstead.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Comment on lines
+483
to
+484
| } | ||
|
|
Contributor
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ⏎
Suggested change
| } | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 1:
When guest plays a playlist, it would just append to the hosts playlist. Added the CLEAR_QUEUE event to sync the playlist clears.
Problem 2:
When the guest plays its playlist, due to CLEAR_QUEUE, the hosts player index is set to -1, so when the guests items are added, nothing plays and the UI gets locked in a not playing state, hence just setting the player index to the start item fixes this (via the SET_INDEX event)