PBM-1649 Support profiles in cleanup and delete-backup

[jcechace]

[Copilot]

Pull Request Overview

This PR adds support for storage profiles in cleanup and delete-backup operations, allowing users to specify a profile when cleaning up or deleting backups stored in different storage configurations.

• Added profile parameter to cleanup and delete-backup commands and their underlying functions
• Updated backup filtering logic to support profile-based queries
• Modified storage initialization to use profile-specific configurations when provided

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
sdk/sdk.go	Added profile field to DeleteBackupBeforeOptions and updated function signatures to pass profile parameter
sdk/impl.go	Updated client methods to accept and pass profile parameter for cleanup and delete operations
pbm/util/storage.go	Added GetProfiledStorage function to retrieve storage configuration from a specific profile
pbm/ctrl/send.go	Updated command sending functions to include profile parameter in delete and cleanup commands
pbm/ctrl/cmd.go	Added Profile field to DeleteBackupCmd and CleanupCmd structures
pbm/backup/delete.go	Updated delete and cleanup functions to filter backups by profile and use profile-specific storage
cmd/pbm/main.go	Added --profile flag to cleanup and delete-backup CLI commands
cmd/pbm/delete.go	Added profile validation and parameter passing in CLI handlers
cmd/pbm-agent/delete.go	Updated agent delete and cleanup handlers to use profile parameter and changed from DeleteBackupFiles to DeleteBackup

Comments suppressed due to low confidence (1)

cmd/pbm-agent/delete.go:265

• The storage instance stg created at line 262 is no longer used after the change to backup.DeleteBackup at line 292. The stg variable is only used for deleting chunks (line 280), so the error handling at line 259 should return early if there's an error, or the storage initialization should be moved closer to where it's actually used (before the chunk deletion loop at line 276).

	stg, err := util.StorageFromConfig(&cfg.Storage, a.brief.Me, l)
	if err != nil {
		l.Error("get storage: " + err.Error())
	}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[boris-ilijic]

Approach looks good, I dropped few comments on some of the (use) cases we need to smooth out.

[boris-ilijic]

Probably we should forbidden delete by name in combination with --profile:

pbm delete <backup-name> --profile p1

In case when backup-name is on default storage or on e.g. p2, above command will still delete backup, so that's kind of misleading.

Alternative is to not delete that backup in case when that backup-name is not present within the profile storage, but I'd recommend the first solution.

[boris-ilijic]

There's one bug related to bulk delete that must be addressed before merging. All other comments are optional.
Once that bug is fixed, the PR is ready to merge.

[boris-ilijic]

This will result in an error during bulk delete on the main storage.

[boris-ilijic]

I would not analyze this at this moment, seems complex and requires time to analyze it better. So, I am suggesting to keep more or less original comments.

[jcechace]

I rephrased the todo, but there there was no comment before.

Since it is complex, I would rather keep it with a note that it might not be accurate (and I'm reasonably certain it is) instead of having to figure it out all over again in the future.