Skip to content

Conversation

@jperichon
Copy link

@jperichon jperichon commented Oct 11, 2017

We wanted to extend the coverage of local hosts detection and also allow blacklisting of some domains (eg: internal domains).

@jperichon jperichon changed the title Better validations against internal URLs POC - Better validations against internal URLs Oct 11, 2017
@jperichon
Copy link
Author

@kritik let me know what you think!

@jperichon jperichon changed the title POC - Better validations against internal URLs Better validations against internal URLs Oct 11, 2017
@kritik
Copy link
Member

kritik commented Oct 12, 2017

@jperichon I like the idea of blacklisted domains but not of internal IPs. It adds big complexity but I don't see any reason why anyone would use that. Maybe spit commits by two merge requests?

@jperichon
Copy link
Author

@kritik Thanks for the quick review, I will split the PR.

I agree on the complexity for detecting internal IPs, but this extended validation can be used to prevent SSRF attacks and make the feature no_local more bulletproof/works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants