-
Notifications
You must be signed in to change notification settings - Fork 50
Make broadcaster dependencies optional #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
An option is available for each backend as well as an "all" option which gets you everything.
Ping @orweis :-) |
Tests fail I currently don't have the CPU to look into this. |
Hi I have improved the PR by:
Unfortunately tests in I don't mind looking into why they fail and potentially fixing it but I think it is outside the scope of this PR. What do you think? Br Eskild |
Apparently the tests failed because the All tests pass locally with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 Breaking Changes Added
LGTM
An option is available for each backend as well as an "all" option which gets you everything.
pip install fastapi_websocket_pubsub
pip install fastapi_websocket_pubsub[redis]
pip install fastapi_websocket_pubsub[postgres]
pip install fastapi_websocket_pubsub[kafka]
pip install fastapi_websocket_pubsub[all]
This PR aims to close #57. I made this PR because it will enable me to install
fastapi_websocket_pubsub
onpython:3.13-alpine
Docker image without first installingbuild-base
andzlib-dev
.Thanks a ton for this library. It's been quite useful and I appreciate that you maintain it and offer it to the community.
Br Eskild