Skip to content

Conversation

nikolawhallon
Copy link
Contributor

This PR does two things:

  • in the music player, the up and down buttons can now adjust the music offset
  • the "pause" label was adjusted slightly - it looked too much like "00" imo (happy to revert this)

This addresses this task: https://www.notion.so/support-music-that-doesnt-start-at-sfx-0-17c996f1fe4180d4a60ec744968d7872?source=copy_link

I will note that this accomplishes two things:

  • if "00" / "01" etc are used for SFX, this allows the user to skip these chunks to where the music actually begins
  • for carts with multiple songs, this allows one to skip ahead beyond the first song (e.g. if "00" -> "03" is a looped song and "04" -> "07" is another looped song, one can seek to that second song now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant