feat: Notify of spending limits UI #335
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafinskipg
changed the title
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
iamacook
reviewed
Nov 25, 2025
Contributor
iamacook
left a comment
iamacook
left a comment
There was a problem hiding this comment.
The UI code is duplicated for React and Native. Can we dedupe that and/or the providers with core React logic?
jkadamczyk
reviewed
Nov 26, 2025
Collaborator
jkadamczyk
left a comment
jkadamczyk
left a comment
There was a problem hiding this comment.
Left mostly nits around some cleanup, otherwise looks good!
iamacook
previously approved these changes
Dec 3, 2025
jkadamczyk
previously approved these changes
Dec 3, 2025
iamacook
reviewed
Dec 3, 2025
iamacook
approved these changes
Dec 3, 2025
iamacook
previously approved these changes
Dec 3, 2025
…ithub.com:phantom/wallet-sdk into rafael/wp-7764-ui-show-error-user-reached-warning
…ithub.com:phantom/wallet-sdk into rafael/wp-7764-ui-show-error-user-reached-warning
iamacook
reviewed
Dec 5, 2025
Comment on lines
+37
to
+39
| if (isAxiosError(error)) { | ||
| return error.message || fallbackMessage; | ||
| } |
Contributor
There was a problem hiding this comment.
This is redundant because of getAxiosErrorData.
Comment on lines
+228
to
+229
| // Also check error.response?.data for manually mocked errors in tests | ||
| const errorData = data || ((error as any)?.response?.data as PrepareErrorResponse | undefined); |
Contributor
There was a problem hiding this comment.
We should not be handling test code in production.
Comment on lines
+22
to
+35
| console.error("No auth provider found in user session"); | ||
| return; | ||
| } | ||
|
|
||
| setIsLoggingOut(true); | ||
| try { | ||
| // Disconnect first | ||
| await disconnect(); | ||
| // Then connect again with the same provider | ||
| await connect({ provider: authProvider }); | ||
| // Close the modal after successful reconnection | ||
| onClose(); | ||
| } catch (error) { | ||
| console.error("Error during logout and login:", error); |
Contributor
There was a problem hiding this comment.
Why are we logging in production? Shouldn't we be using our logger?
auto-merge was automatically disabled
December 9, 2025 14:21
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listens to the event returned by wallet-service when a user reached spending limits and renders a modal.
In future PRs we will: