add productFromDiagonalMatrix method #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the implementation of element wise multiplication of diagonal matrices faster.
Pull Request Test Coverage Report for Build 14
💛 - Coveralls |
3 similar comments
Pull Request Test Coverage Report for Build 14
💛 - Coveralls |
Pull Request Test Coverage Report for Build 14
💛 - Coveralls |
Pull Request Test Coverage Report for Build 14
💛 - Coveralls |
|
@hernanmd can you please review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when we perform the element-wise multiplication of AIDiagonalMatrix with another matrix, we never took into account that only diagonal elements have to be multiplied as other elements would anyway be zero.
This PR introduces a new method
productFromDiagonalMatrixthat multiplies only the diagonal elements of the argument(AIDiagonalmatrix) with the receiver(AIMatrix) and returns the argument.