Fix Fate JavaScript error + consistent setup + builds for each project #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All index.html have the same setup. With a div#game-container in it. However, some setups had
contenedoras a selector configured for parent. Which then makes it fallback on the default, which is mounting on the body element.Some didn't have a reference to the parent to mount to.
This pull requests makes all the setup consistent. It also fixes the Fate project, where there was an error with how the string concatenation was formatted.
I ran
npm run buildin each project to generate a dist, since a lot of them had an index referencingTemplateinstead of the title of the project.