Several improvements, if ya'll are interested #2
Conversation
jnankin
left a comment
jnankin
left a comment
There was a problem hiding this comment.
I wrote this back when I was a PHP guy, so all the method names are camel case. I think the ruby convention is snake_case. New code should probably be switched to snake case and not make this worse.
| Send faxes with Phaxio using 3rd party email services. Mailphax is a simple sinatra app. You can run it on any host or with any service that supports ruby and sinatra. | ||
|
|
||
|
|
||
| Installation on Heroku |
There was a problem hiding this comment.
Any reason this is being removed?
There was a problem hiding this comment.
Botch pull-request branch. This was intended for strictly a work-related project. Undone in #3.
app.json
Outdated
| } | ||
| }, | ||
| "repository" : "https://github.com/phaxio/mailphax", | ||
| "repository" : "https://gitlab.com/tsltd/mailphax.git", |
|
|
||
| if not ENV['PHAXIO_KEY'] or not ENV['PHAXIO_SECRET'] | ||
| raise "You must specify your phaxio API keys in PHAXIO_KEY and PHAXIO_SECRET" | ||
| if not ENV['PHAXIO_KEY'] or not ENV['PHAXIO_SECRET'] or not ENV['MAILGUN_KEY'] |
There was a problem hiding this comment.
mailgun is not necessarily required for all installations
There was a problem hiding this comment.
I see now that you addressed this in your comments and removed the other mail providers. you're probably right. we don't have the man power right now to implement the other providers unless they're requested.
| $recipientWhitelist = nil | ||
|
|
||
| def getRecipientWhitelist() | ||
| if $recipientWhitelist.nil? |
There was a problem hiding this comment.
We should document these features in the readme (the new whitelists)
There was a problem hiding this comment.
I think they are useful, and so I've added to the pull request, but I can also see it being too granular. If it is a worthwhile feature, I can add some documentation.
|
I have done goofed. I forgot this pull request existed, and I have been recently working on this branch for some work-project related functionality. Please, allow me to close this pull request and resubmitted it on a more appropriately named branch, without some of the work-related specifics. |
3 participants
Removing Mandrill and SendGrid, as they weren't implemented and didn't look like they would be.
Adding ability to send email body as one of the fax attachments.
Adding security features: Whitelisting recipients/senders, regex to ensure body is safe, ensuring signature of Mailgun is correct.
Adding Environment variables: MAILGUN_KEY. RECIPIENT_WHITELIST_FILE, SENDER_WHITELIST_FILE, BODY_REGEX.