Skip to content

Conversation

philenius
Copy link
Owner

@philenius philenius commented Jun 9, 2025

Upgrade to Angular 19 as requested in #33

@philenius philenius requested a review from Copilot June 9, 2025 18:27
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request upgrades the application to Angular 19 and updates supporting dependencies and configuration files.

  • Upgrade Angular framework dependencies and CLI versions in package.json and angular.json.
  • Update bootstrap CDN URL and integrity hash in index.html.
  • Migrate components to standalone mode and adjust module and test configurations accordingly.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/index.html Updated bootstrap version and integrity attribute.
src/app/app.config.ts Minor formatting update with a trailing comma added in the providers.
src/app/app.component.html Modified array reversal in template to avoid mutating original array.
projects/ngx-annotate-text/src/lib/ngx-annotate-text.module.ts Transitioned component declarations to standalone component imports.
projects/ngx-annotate-text/src/lib/components/ngx-annotate-text/ngx-annotate-text.component.ts Converted component to standalone with proper imports.
projects/ngx-annotate-text/src/lib/components/ngx-annotate-text/ngx-annotate-text.component.spec.ts Updated spec configuration with standalone components.
projects/ngx-annotate-text/src/lib/components/annotation-renderer/annotation-renderer.components.ts Marked component as standalone.
projects/ngx-annotate-text/src/lib/components/annotation-renderer/annotation-renderer.component.spec.ts Updated spec configuration with standalone component import.
projects/ngx-annotate-text/src/lib/components/annotation-renderer/annotation-renderer.component.html Adopted Angular’s new template syntax for conditionals.
projects/ngx-annotate-text/package.json Bumped dependency versions to Angular 19.
package.json Updated root dependencies and devDependencies to Angular 19.
angular.json Adjusted asset size thresholds.
README.md Updated CLI commands and instructions for Angular 19.
Comments suppressed due to low confidence (2)

src/index.html:10

  • Ensure that the updated Bootstrap version and its corresponding integrity hash have been verified against the official release to avoid potential mismatches.
href="https://cdn.jsdelivr.net/npm/bootstrap@5.3.6/dist/css/bootstrap.min.css"

projects/ngx-annotate-text/src/lib/components/annotation-renderer/annotation-renderer.component.html:23

  • [nitpick] Ensure consistent indentation for the @if block in the template to improve readability; consider aligning the nested markup uniformly.
@if (removable) {

@philenius philenius changed the title feat: update to Angular 19 feat: upgrade to Angular 19 Jun 9, 2025
@philenius philenius merged commit 0f8b126 into main Jun 9, 2025
1 check passed
@philenius philenius deleted the feat/update-to-angular-19 branch June 9, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant