Skip to content

Conversation

philenius
Copy link
Owner

Upgrade to Angular 20 as requested in #33

@philenius philenius requested a review from Copilot June 9, 2025 20:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the workspace and library to Angular 20, adjusts TypeScript configurations for new default includes, migrates to the new @angular/build builders, and adopts the inject() DI API.

  • Update project and library tsconfig.*.json include/exclude patterns
  • Switch Angular builders in angular.json to @angular/build
  • Bump Angular dependencies to ^20.0.0 and migrate DI to inject()
  • Add provideBrowserGlobalErrorListeners to app.config.ts and update library component DI

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tsconfig.spec.json Broaden include to all .ts files (test runner)
tsconfig.app.json Include all .ts, exclude specs for application build
src/app/app.config.ts Add global error listeners provider
projects/ngx-annotate-text/tsconfig.spec.json Broaden include to all .ts files for library tests
projects/ngx-annotate-text/tsconfig.lib.json Include all .ts, exclude specs for library
projects/ngx-annotate-text/src/.../ngx-annotate-text.component.ts Replace constructor DI with inject()
projects/ngx-annotate-text/package.json Bump library version and peer dependencies to Angular 20
package.json Bump workspace Angular dev and peer dependencies to Angular 20
angular.json Migrate to @angular/build builders and simplified options
README.md Update CLI and ESLint schematics to version 20
CHANGELOG.md Add release notes for v20.0.0
Comments suppressed due to low confidence (3)

tsconfig.spec.json:9

  • The spec tsconfig no longer includes .d.ts files, which may omit ambient type declarations during testing. Consider restoring "src/**/*.d.ts" in the include array.
"include": ["src/**/*.ts"]

projects/ngx-annotate-text/tsconfig.spec.json:9

  • Similar to the workspace spec tsconfig, this file no longer includes .d.ts definitions. Add "src/**/*.d.ts" back to ensure ambient declarations are picked up in tests.
"include": ["src/**/*.ts"]

projects/ngx-annotate-text/src/lib/components/ngx-annotate-text/ngx-annotate-text.component.ts:29

  • Make sure ElementRef and TokenizerService are imported at the top of this file when switching to inject(). Missing imports will cause build errors.
private elementRef: ElementRef = inject(ElementRef);

@philenius philenius merged commit f6ac46b into main Jun 9, 2025
1 check passed
@philenius philenius deleted the feat/upgrade-to-angular-20 branch June 9, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant