Add opcache_preloading() internal function #19288
Conversation
| @@ -220,6 +220,7 @@ typedef struct _zend_accel_globals { | |||
| #endif | |||
| void *preloaded_internal_run_time_cache; | |||
| size_t preloaded_internal_run_time_cache_size; | |||
| bool preloading; | |||
There was a problem hiding this comment.
I don't know much about packing data structure declarations to reduce space, would it be better to put this next to the other bool fields above?
There was a problem hiding this comment.
I hesitated, as I was weighting the benefits of packing vs placing the fields near related fields. I chose the latter because there is only one "instance" of this struct at a time, so this should not make a huge difference.
| @@ -444,6 +447,7 @@ static const zend_function_entry ext_functions[] = { | |||
| ZEND_FE(zend_test_log_err_debug, arginfo_zend_test_log_err_debug) | |||
| ZEND_FE(zend_test_compile_to_ast, arginfo_zend_test_compile_to_ast) | |||
| ZEND_FE(zend_test_gh18756, arginfo_zend_test_gh18756) | |||
| ZEND_FE(zend_test_opcache_preloading, arginfo_zend_test_opcache_preloading) | |||
There was a problem hiding this comment.
given that the relevant function is only being introduced in PHP 8.5, it doesn't make sense for zend_test_opcache_preloading() to exist on 8.4 or below, right? It would probably break if you tried to call it - suggest putting version guards around the declaration in the stub file
There was a problem hiding this comment.
This will not be merged in 8.4, so the zend_test_opcache_preloading() function will not exist in 8.4 :)
There was a problem hiding this comment.
No, but it appears that zend_test supports running the new versions of the extension with older versions of PHP, since we generate arginfo to support older versions of PHP
There was a problem hiding this comment.
If that's supported I don't think it's on purpose. To support old versions, adding guards in the stub wouldn't be enough, we would also need conditional directives in the implementation.
There was a problem hiding this comment.
Older versions of the arginfo are generated as a smoke test for the generator.
|
I wonder what the motivation is? |
|
@nielsdos Similar motivation as here: #14479 (comment) |
Add a C function
opcache_preloading()that returnstrueduring preloading. Extensions can use this to detect preloading, not only during compilation/execution, but also inRINIT()/RSHUTDOWN().Since opcache currently doesn't install any header, I'm adding a new one:
zend_accelerator_api.h. Header name is based on other files inext/opcache.