php 8 changes in full.php and rbac.php causes issue in function descendants($ID) #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… project files in gitignore
…e interpreted as $AbsoluteDepths, fixed this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
descendants issue
in function descendants($ID) the parameter $ID is set and causes issue in
$res = $this->{$this->type()}->descendantsConditional("ID=?", $ID, false);
$ID is interpreted as depth since
in PhpRbac/src/PhpRbac/core/lib/nestedset/full.php
it is set this way:
function descendantsConditional($ConditionString,$AbsoluteDepths=false);
=> recommand to make depth 2nd parameter to match with line 15 of PhpRbac/src/PhpRbac/core/lib/nestedset/full.php
(WIP, should be also considered in function siblingConditional)
add omit in gitignore for jetbrains, vendor, composer.lock