default to using the ZK server’s cfg #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a ZooKeeper server is installed on the system, zktop is likely expected to connected to the ZK enseble of that and not only to the local ZK server. • Set a default path for a ZooKeeper server configuration file to "/etc/zookeeper/conf/zoo.cfg". This value should be adapted by distributions to their respective ZooKeeper server package’s default path. • Unless “--server” is explicitly given and if the ZooKeeper server configuration file exists (is a regular file or a symlink to it) at the default path, use the later for determining to which ZooKeeper servers to connect. • Updated the documentation for these changes. • Added a note that with Python2, zktop now requires pathlib to be installed. Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
Author
|
@phunt Hey... anything new on this? |
Owner
|
Thanks @calestyo - tbh though I think when I looked at it originally (granted it's been a while...) I thought that I wanted to optimize for local usage as the default. I also didn't think that /etc/... was universal. Python2 should be removed entirely at this point given it's EOL for a while now. |
Author
|
Not sure what you mean... doesn't it make just sense to use the config if it's there and if not fall back to the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a ZooKeeper server is installed on the system, zktop is likely expected to
connected to the ZK enseble of that and not only to the local ZK server.
• Set a default path for a ZooKeeper server configuration file to
"/etc/zookeeper/conf/zoo.cfg".
This value should be adapted by distributions to their respective ZooKeeper
server package’s default path.
• Unless “--server” is explicitly given and if the ZooKeeper server
configuration file exists (is a regular file or a symlink to it) at the
default path, use the later for determining to which ZooKeeper servers to
connect.
• Updated the documentation for these changes.
• Added a note that with Python2, zktop now requires pathlib to be installed.
Signed-off-by: Christoph Anton Mitterer mail@christoph.anton.mitterer.name