Skip to content

Add no-op defaults to all delegate methods to make them optional #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsheaff wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add no-op defaults to all delegate methods to make them optional #243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions Sources/Player.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,24 @@ public protocol PlayerPlaybackDelegate: AnyObject {
func playerPlaybackDidLoop(_ player: Player)
}

// Provide default implementations for all delegate methods so that they are all optional
// See https://stackoverflow.com/questions/24032754/how-to-define-optional-methods-in-swift-protocol
extension PlayerDelegate {
func playerReady(_ player: Player) {}
func playerPlaybackStateDidChange(_ player: Player) {}
func playerBufferingStateDidChange(_ player: Player) {}
func playerBufferTimeDidChange(_ bufferTime: Double) {}
func player(_ player: Player, didFailWithError error: Error?) {}
}

extension PlayerPlaybackDelegate {
func playerCurrentTimeDidChange(_ player: Player) {}
func playerPlaybackWillStartFromBeginning(_ player: Player) {}
func playerPlaybackDidEnd(_ player: Player) {}
func playerPlaybackWillLoop(_ player: Player) {}
func playerPlaybackDidLoop(_ player: Player) {}
}

// MARK: - Player

/// ▶️ Player, simple way to play and stream media
Expand Down