Skip to content

Conversation

@huoyao1125
Copy link

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 27, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 27, 2025

Hi @huoyao1125. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gemini-code-assist
Copy link

Summary of Changes

Hello @huoyao1125, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the documentation for TiDB Cloud's Prometheus and Grafana integration. The core changes reflect the upcoming General Availability (GA) of the cluster-level Prometheus integration, removing its 'Preview' status throughout the document, and introducing a clear deprecation timeline for the older project-level integration, encouraging users to transition to the newer, more robust solution.

Highlights

  • Cluster-level Prometheus Integration GA: The documentation now announces that the cluster-level Prometheus integration will become Generally Available (GA) starting December 2, 2025.
  • Removal of 'Preview' Status: The 'Preview' designation has been removed from all mentions of the cluster-level Prometheus integration, indicating its transition to a stable release.
  • Legacy Integration Deprecation: A deprecation date of January 6, 2026, has been added for the legacy project-level Prometheus integration, along with a recommendation for users to migrate to the new cluster-level integrations.
  • Expanded Availability: The previous note restricting cluster-level Prometheus integration (Preview) to AWS and Google Cloud has been removed, implying broader availability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 27, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation to reflect that the cluster-level Prometheus integration is now Generally Available (GA), removing the 'Preview' labels throughout the document. The changes are consistent and correct. I have one suggestion to fix what appears to be a missing hyperlink for the migration guide, ensuring users can easily find the necessary instructions.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@hfxsd hfxsd self-assigned this Nov 28, 2025
@hfxsd hfxsd added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Nov 28, 2025
@hfxsd hfxsd self-requested a review November 28, 2025 08:36
@hfxsd hfxsd changed the title Update monitor-prometheus-and-grafana-integration.md cloud: Prometheus integration (Preview) becomes GA Dec 1, 2025
@hfxsd
Copy link
Collaborator

hfxsd commented Dec 1, 2025

/retest

@lilin90 lilin90 added area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. labels Dec 1, 2025
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 1, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 1, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-01 07:49:42.063875872 +0000 UTC m=+249726.877653454: ☑️ agreed by hfxsd.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 2, 2025

@handlerww: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd added the lgtm label Dec 2, 2025
@hfxsd
Copy link
Collaborator

hfxsd commented Dec 2, 2025

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Dec 2, 2025
@hfxsd hfxsd closed this Dec 2, 2025
@hfxsd hfxsd reopened this Dec 2, 2025
@hfxsd
Copy link
Collaborator

hfxsd commented Dec 2, 2025

/approve

@hfxsd hfxsd closed this Dec 2, 2025
@hfxsd hfxsd reopened this Dec 2, 2025
@hfxsd
Copy link
Collaborator

hfxsd commented Dec 2, 2025

/approve

@hfxsd hfxsd closed this Dec 2, 2025
@hfxsd hfxsd reopened this Dec 2, 2025
@hfxsd hfxsd closed this Dec 2, 2025
@hfxsd hfxsd reopened this Dec 2, 2025
@hfxsd
Copy link
Collaborator

hfxsd commented Dec 2, 2025

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@purelind
Copy link

purelind commented Dec 2, 2025

/test pull-verify

@purelind
Copy link

purelind commented Dec 2, 2025

/test ?

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 2, 2025

@purelind: The following commands are available to trigger required jobs:

/test pull-verify

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit b43a129 into pingcap:release-8.5 Dec 2, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/tidb-cloud This PR relates to the area of TiDB Cloud. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. for-cloud-release This PR is related to TiDB Cloud release. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants