Skip to content

Conversation

@asddongmen
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 6, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 6, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign asddongmen for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link

Summary of Changes

Hello @asddongmen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing observability and introducing a deliberate delay within the UpdateChangefeed API endpoint. It adds detailed logging statements to trace the execution path and measure the duration of key operations, which can be useful for debugging or performance analysis. Additionally, a significant sleep duration has been introduced in a critical table verification step, likely for testing timeout scenarios or specific behavioral observations.

Highlights

  • Introduced a significant delay: A 120-second (2-minute) sleep has been added to the getVerifiedTables function, which is likely for testing or debugging purposes related to timeouts or long-running operations.
  • Enhanced Logging: Extensive log.Info and log.Error statements have been added throughout the UpdateChangefeed API endpoint, including timing measurements, to provide detailed insights into the execution flow and performance of various sub-operations.
  • Improved Error Tracing: Error handling has been updated to wrap errors with errors.Trace(err) in several places within the UpdateChangefeed function, which helps in preserving the stack trace for better debugging.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 6, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds extensive logging to the UpdateChangefeed function and introduces a hardcoded 120-second sleep in getVerifiedTables. The sleep will cause severe performance degradation and must be removed. The added logging appears to be for temporary debugging; it is overly verbose, logs potentially sensitive information, and should also be removed before merging.

storage tidbkv.Storage, startTs uint64,
scheme string, topic string, protocol config.Protocol,
) ([]string, []string, error) {
time.Sleep(120 * time.Second)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

A hardcoded sleep of 120 seconds has been introduced. This will severely impact the performance of getVerifiedTables and any operations that call it, such as creating or updating a changefeed. This appears to be temporary code for debugging or testing and must be removed before merging.

Comment on lines +739 to +740
log.Info("UpdateChangefeed")
startTime := time.Now()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PR introduces extensive logging in UpdateChangefeed (e.g., lines 739, 766, 774, 782, 833, 838, 862, 867, 880, 885, 892) which appears to be for temporary debugging. Logging entire objects with zap.Any can be verbose, impact performance, and leak sensitive data. This debugging code should be removed before merging.

Signed-off-by: dongmen <414110582@qq.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 6, 2026

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant